[PATCH] http2: fix check for `frame->hd.type`
authorhanguanqiang <hanguanqiang@kylinos.cn>
Wed, 9 Apr 2025 11:48:11 +0000 (19:48 +0800)
committerJérémy Lal <kapouer@melix.org>
Tue, 24 Mar 2026 21:11:25 +0000 (22:11 +0100)
commita3a0779c312b293ec8f9b02e404f15834df450b3
tree74aa62f6a7e228816f3b876d843874b9aa1c385e
parent85d2164deb8adc940f819e993d84b98951e10c26
[PATCH] http2: fix check for `frame->hd.type`

Related to CVE-2025-23085
According to the comment, this should be checking whether
`frame->hd.type` is `NGHTTP2_GOAWAY`, i.e. `0x07` and not `0x03`.

PR-URL: https://github.com/nodejs/node/pull/57644
Refs: https://github.com/nodejs/node/commit/1b693fa03a0d36bc1dc9ec8d95060e3e5ceeee7b
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Gbp-Pq: Topic sec
Gbp-Pq: Name 12-http2-fix-check-for-frame-type-goaway.patch
src/node_http2.cc
test/parallel/test-http2-premature-close.js